fix(utils): improve ANSI handling and logging debug information#720
Open
Kaibalya-Mohanty wants to merge 7 commits intokubeflow:mainfrom
Open
fix(utils): improve ANSI handling and logging debug information#720Kaibalya-Mohanty wants to merge 7 commits intokubeflow:mainfrom
Kaibalya-Mohanty wants to merge 7 commits intokubeflow:mainfrom
Conversation
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
- Improved ANSI escape sequence handling with robust regex - Added type safety for non-string inputs - Enhanced logging with debug statements for better traceability Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Kaibalya-Mohanty
changed the title
Collaborator
|
hi @Kaibalya-Mohanty I believe this PR should not have the DocString changes from #714 |
Author
|
@ada333 Thanks for pointing this out! |
Updated docstrings to be more concise while retaining essential information. Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves utility functions in kale/utils.py.
Changes
Motivation
This change improves log readability and debugging experience.
Impact